Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@releng - fix pipeline issues and tests #326

Merged
merged 5 commits into from
May 27, 2024
Merged

@releng - fix pipeline issues and tests #326

merged 5 commits into from
May 27, 2024

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented May 21, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.50%. Comparing base (edde07c) to head (5fcfd68).

Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #326       +/-   ##
=============================================
+ Coverage     50.74%   85.50%   +34.76%     
- Complexity       25       42       +17     
=============================================
  Files             2        2               
  Lines            67       69        +2     
  Branches          6        7        +1     
=============================================
+ Hits             34       59       +25     
+ Misses           30        6       -24     
- Partials          3        4        +1     
Flag Coverage Δ
unittests 85.50% <100.00%> (+34.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LSantha
Copy link
Collaborator Author

LSantha commented May 23, 2024

@asilaghi can you have a look at his?

@LSantha LSantha changed the title @releng - fix uit tests @releng - fix pipeline issues and tests May 23, 2024
Copy link
Collaborator

@asilaghi asilaghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LSantha LSantha merged commit 300b70a into dev May 27, 2024
10 checks passed
@LSantha LSantha deleted the fix-ui-tests branch May 27, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants