CIF-2144 - Disable mangling because of bug in graphql library #172

herzog31 · 2021-07-26T09:20:50Z

Description

Temporarily disable mangling as part of the webpack minification because of Getting realm related error in console if using webpack.UglifyJsPlugin graphql/graphql-js#1182.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

@releng

* CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * @releng - update CIF Core Components dependency to SNAPSHOT version * CIF-1718 - Adopt Magento GraphQL schema changes - Category UID - update graphql dependency to 2.4.2 EE to align with CIF components * @trivial - update dependencies (#129) * CIF-2007 - Use latest releases of CIF Add-on for IT and UI tests (#132) * CIF-2007 - Use latest release of CIF add-on from artifactory * CIF-2007 - Use latest release of CIF add-on from artifactory * CIF-2007 - Use latest release of CIF add-on from artifactory * CIF-2007 - Use latest release of CIF add-on for AEM 6.5 from artifactory * CIF-2007 - Fix UI tests * @releng Update dependency versions (#134) Update `AEM Core CIF Components` to 1.11.0 and `@adobe/aem-core-cif-react-components` to 1.11.0 Co-authored-by: Daniel Platon <platon@adobe.com> * CIF-2086: Update react-components to be in sync with CIF Components version (#133) * CIF-2086: Sync reac-components version on release * CIF-2086: Commit updated npm files * CIF-2086: Fix npm files commit profile * CIF-2086: Update cif-react-components dependency * Remove package-lock.json from .gitignore Co-authored-by: Daniel Platon <platon@adobe.com> * CIF-2032 - Category page mapping for UID + URL_PATH (#131) * Category page mapping for UID + URL_PATH * Update cloudready image * Update casssic image * CIF-2065 - Set affinity cookie for all requests in WDIO tests (#135) * CIF-2065 - Set affinity cookie for all requests in WDIO tests * releng - Update cloudready image to 5343 * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * trivial - fix pom.xml from re-base Co-authored-by: Christophe Jelger <jelger@adobe.com> Co-authored-by: Levente Santha <levente@adobe.com> Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com> Co-authored-by: Daniel Platon <dplaton@pm.me> Co-authored-by: Daniel Platon <platon@adobe.com> Co-authored-by: Laurentiu Magureanu <magurean@adobe.com>

* CIF-2107 - Add Magento Storefront Events SDK * CIF-2107 - Add Magento Storefront Events SDK * CIF-1724: Load storefront events collector Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com> Co-authored-by: Markus Haack <mhaack@adobe.com>

* CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * CIF-2131 - remove "id" support for AEM Venia Co-authored-by: Christophe Jelger <jelger@adobe.com> Co-authored-by: Levente Santha <levente@adobe.com> Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com>

- use the newly introduced, fixed patterns for the UrlProvider

* use product collection v2 and searchresults v2 in Venia * added Venia styling for productcollection component * cleaned up Venia styling for productlist and searchresults component

…nt (#166) * CIF-2227 - add missing image alt attribute for product teaser component * CIF.2227 - improve tests * CIF-2227 - fix test

) * CIF-2211 - Update core WCM dependency to latest for CIF components * updated core.wcm.components.version to 2.17.2 * CIF-2211 - Update core WCM dependency to latest for CIF components * updated docker images * CIF-2211 - Update core WCM dependency to latest for CIF components * stick to the circleci-aem:6.5.8-azul image in CI for now

* CIF-2144 - Add basic extension react component project * CIF-2144 - Add support for Apollo client dependency sharing * CIF-2144 - Add PortalPlacer * CIF-2143: Add product recs to Venia * CIF-2143: Fix dependencies * CIF-2144 - Add todo * CIF-2143: Fix dependencies in all package * CIF-2144 - Update i18n config * CIF-2144 - Add feedback * CIF-2144 - Rename npm package * CIF-2144 - Update npm dependencies * Update GraphQL Client Version * CIF-2144 - Update npm dependencies

codecov · 2021-07-26T10:00:25Z

Codecov Report

Merging #172 (b39eb7e) into main (8c9a86b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #172   +/-   ##
=========================================
  Coverage     85.71%   85.71%           
  Complexity       18       18           
=========================================
  Files             1        1           
  Lines            28       28           
  Branches          4        4           
=========================================
  Hits             24       24           
  Misses            2        2           
  Partials          2        2

Flag	Coverage Δ
unittests	`85.71% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9a86b...b39eb7e. Read the comment docs.

This reverts commit 8d27598.

mhaack and others added 20 commits June 29, 2021 12:02

update to cif 2.0 api (#154)

015ee1f

CIF-2062 - adjust UrlProvider config and Sling map (#150)

8617e3b

- use the newly introduced, fixed patterns for the UrlProvider

CIF-2143: Create Product Recommendations AEM component (#152)

cd2e129

CIF-2038: Migrate to CircleCI contexts (#155)

799c018

CIF-2153 - use Button v2 (#156)

a0dba40

CIF-2193: use CIF page v2 component (#159)

883470a

CIF-1926: add minimal default styling for cif navigation (#158)

d024e31

CIF-1380: add product collection component styling (#157)

4d13738

* use product collection v2 and searchresults v2 in Venia * added Venia styling for productcollection component * cleaned up Venia styling for productlist and searchresults component

CIF-2155: update to use new v2 commerce teaser (#162)

fae0941

CIF-2222: enable storefront context rendering (#167)

f165754

CIF-2227 - add missing image alt attribute for product teaser compone…

aaba902

…nt (#166) * CIF-2227 - add missing image alt attribute for product teaser component * CIF.2227 - improve tests * CIF-2227 - fix test

Fix unit tests broken by UrlProvider package change (#168)

2bdb1cb

releng - Update CIF Core Components to 2.0.0 (#169)

fddd390

Merge branch 'main' into dev

2fd0ecf

CIF-2144 - Disable mangling because of bug in graphql library

a054028

herzog31 added the bug Something isn't working label Jul 26, 2021

herzog31 requested review from dplaton and laurentiumagureanu July 26, 2021 09:20

herzog31 added 2 commits July 26, 2021 11:24

releng - Enforce production build (to be reverted)

8d27598

CIF-2144 - Disable mangling because of bug in graphql library

cb8015d

Revert "releng - Enforce production build (to be reverted)"

80c2107

This reverts commit 8d27598.

laurentiumagureanu changed the base branch from dev to main July 26, 2021 10:04

Merge branch 'main' into bug/CIF-2144-graphql

b39eb7e

laurentiumagureanu approved these changes Jul 26, 2021

View reviewed changes

laurentiumagureanu merged commit f5d717b into main Jul 26, 2021

laurentiumagureanu deleted the bug/CIF-2144-graphql branch July 26, 2021 10:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CIF-2144 - Disable mangling because of bug in graphql library #172

CIF-2144 - Disable mangling because of bug in graphql library #172

herzog31 commented Jul 26, 2021

codecov bot commented Jul 26, 2021 •

edited

Loading

CIF-2144 - Disable mangling because of bug in graphql library #172

CIF-2144 - Disable mangling because of bug in graphql library #172

Conversation

herzog31 commented Jul 26, 2021

Description

Types of changes

Checklist:

codecov bot commented Jul 26, 2021 • edited Loading

Codecov Report

codecov bot commented Jul 26, 2021 •

edited

Loading