CIF-2131 - remove "id" support for AEM Venia #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector
* use productlist v2 component * update css for consistent "staged" flag in product and productlist
* add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector
* use productlist v2 component * update css for consistent "staged" flag in product and productlist
… 2.0.0-ee # Conflicts: # .circleci/ci/it-tests.js
herzog31
approved these changes
Jun 29, 2021
10 tasks
Codecov Report
@@ Coverage Diff @@
## dev #151 +/- ##
=========================================
Coverage 85.18% 85.18%
Complexity 17 17
=========================================
Files 1 1
Lines 27 27
Branches 4 4
=========================================
Hits 23 23
Misses 2 2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
laurentiumagureanu
added a commit
that referenced
this pull request
Jul 26, 2021
* 2.0.0 ee (#149) * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * @releng - update CIF Core Components dependency to SNAPSHOT version * CIF-1718 - Adopt Magento GraphQL schema changes - Category UID - update graphql dependency to 2.4.2 EE to align with CIF components * @trivial - update dependencies (#129) * CIF-2007 - Use latest releases of CIF Add-on for IT and UI tests (#132) * CIF-2007 - Use latest release of CIF add-on from artifactory * CIF-2007 - Use latest release of CIF add-on from artifactory * CIF-2007 - Use latest release of CIF add-on from artifactory * CIF-2007 - Use latest release of CIF add-on for AEM 6.5 from artifactory * CIF-2007 - Fix UI tests * @releng Update dependency versions (#134) Update `AEM Core CIF Components` to 1.11.0 and `@adobe/aem-core-cif-react-components` to 1.11.0 Co-authored-by: Daniel Platon <platon@adobe.com> * CIF-2086: Update react-components to be in sync with CIF Components version (#133) * CIF-2086: Sync reac-components version on release * CIF-2086: Commit updated npm files * CIF-2086: Fix npm files commit profile * CIF-2086: Update cif-react-components dependency * Remove package-lock.json from .gitignore Co-authored-by: Daniel Platon <platon@adobe.com> * CIF-2032 - Category page mapping for UID + URL_PATH (#131) * Category page mapping for UID + URL_PATH * Update cloudready image * Update casssic image * CIF-2065 - Set affinity cookie for all requests in WDIO tests (#135) * CIF-2065 - Set affinity cookie for all requests in WDIO tests * releng - Update cloudready image to 5343 * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * trivial - fix pom.xml from re-base Co-authored-by: Christophe Jelger <jelger@adobe.com> Co-authored-by: Levente Santha <levente@adobe.com> Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com> Co-authored-by: Daniel Platon <dplaton@pm.me> Co-authored-by: Daniel Platon <platon@adobe.com> Co-authored-by: Laurentiu Magureanu <magurean@adobe.com> * CIF-1724: Add Magento Storefront Events Collector (#142) * CIF-2107 - Add Magento Storefront Events SDK * CIF-2107 - Add Magento Storefront Events SDK * CIF-1724: Load storefront events collector Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com> Co-authored-by: Markus Haack <mhaack@adobe.com> * update to cif 2.0 api (#154) * CIF-2131 - remove "id" support for AEM Venia (#151) * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * CIF-2131 - remove "id" support for AEM Venia Co-authored-by: Christophe Jelger <jelger@adobe.com> Co-authored-by: Levente Santha <levente@adobe.com> Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com> * CIF-2062 - adjust UrlProvider config and Sling map (#150) - use the newly introduced, fixed patterns for the UrlProvider * CIF-2143: Create Product Recommendations AEM component (#152) * CIF-2038: Migrate to CircleCI contexts (#155) * CIF-2153 - use Button v2 (#156) * CIF-2193: use CIF page v2 component (#159) * CIF-1926: add minimal default styling for cif navigation (#158) * CIF-1380: add product collection component styling (#157) * use product collection v2 and searchresults v2 in Venia * added Venia styling for productcollection component * cleaned up Venia styling for productlist and searchresults component * CIF-2155: update to use new v2 commerce teaser (#162) * CIF-2222: enable storefront context rendering (#167) * CIF-2227 - add missing image alt attribute for product teaser component (#166) * CIF-2227 - add missing image alt attribute for product teaser component * CIF.2227 - improve tests * CIF-2227 - fix test * Fix unit tests broken by UrlProvider package change (#168) * CIF-2211 - Update core WCM dependency to latest for CIF components (#165) * CIF-2211 - Update core WCM dependency to latest for CIF components * updated core.wcm.components.version to 2.17.2 * CIF-2211 - Update core WCM dependency to latest for CIF components * updated docker images * CIF-2211 - Update core WCM dependency to latest for CIF components * stick to the circleci-aem:6.5.8-azul image in CI for now * releng - Update CIF Core Components to 2.0.0 (#169) * CIF-2144 - Create a React project with a Recommendation component (#153) * CIF-2144 - Add basic extension react component project * CIF-2144 - Add support for Apollo client dependency sharing * CIF-2144 - Add PortalPlacer * CIF-2143: Add product recs to Venia * CIF-2143: Fix dependencies * CIF-2144 - Add todo * CIF-2143: Fix dependencies in all package * CIF-2144 - Update i18n config * CIF-2144 - Add feedback * CIF-2144 - Rename npm package * CIF-2144 - Update npm dependencies * Update GraphQL Client Version * CIF-2144 - Update npm dependencies Co-authored-by: Markus Haack <mhaack@adobe.com> Co-authored-by: Christophe Jelger <jelger@adobe.com> Co-authored-by: Levente Santha <levente@adobe.com> Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com> Co-authored-by: Daniel Platon <dplaton@pm.me> Co-authored-by: Daniel Platon <platon@adobe.com> Co-authored-by: Dirk Rudolph <diru91@gmail.com>
LSantha
added a commit
that referenced
this pull request
Aug 27, 2021
* 2.0.0 ee (#149) * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * @releng - update CIF Core Components dependency to SNAPSHOT version * CIF-1718 - Adopt Magento GraphQL schema changes - Category UID - update graphql dependency to 2.4.2 EE to align with CIF components * @trivial - update dependencies (#129) * CIF-2007 - Use latest releases of CIF Add-on for IT and UI tests (#132) * CIF-2007 - Use latest release of CIF add-on from artifactory * CIF-2007 - Use latest release of CIF add-on from artifactory * CIF-2007 - Use latest release of CIF add-on from artifactory * CIF-2007 - Use latest release of CIF add-on for AEM 6.5 from artifactory * CIF-2007 - Fix UI tests * @releng Update dependency versions (#134) Update `AEM Core CIF Components` to 1.11.0 and `@adobe/aem-core-cif-react-components` to 1.11.0 Co-authored-by: Daniel Platon <platon@adobe.com> * CIF-2086: Update react-components to be in sync with CIF Components version (#133) * CIF-2086: Sync reac-components version on release * CIF-2086: Commit updated npm files * CIF-2086: Fix npm files commit profile * CIF-2086: Update cif-react-components dependency * Remove package-lock.json from .gitignore Co-authored-by: Daniel Platon <platon@adobe.com> * CIF-2032 - Category page mapping for UID + URL_PATH (#131) * Category page mapping for UID + URL_PATH * Update cloudready image * Update casssic image * CIF-2065 - Set affinity cookie for all requests in WDIO tests (#135) * CIF-2065 - Set affinity cookie for all requests in WDIO tests * releng - Update cloudready image to 5343 * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * trivial - fix pom.xml from re-base Co-authored-by: Christophe Jelger <jelger@adobe.com> Co-authored-by: Levente Santha <levente@adobe.com> Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com> Co-authored-by: Daniel Platon <dplaton@pm.me> Co-authored-by: Daniel Platon <platon@adobe.com> Co-authored-by: Laurentiu Magureanu <magurean@adobe.com> * CIF-1724: Add Magento Storefront Events Collector (#142) * CIF-2107 - Add Magento Storefront Events SDK * CIF-2107 - Add Magento Storefront Events SDK * CIF-1724: Load storefront events collector Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com> Co-authored-by: Markus Haack <mhaack@adobe.com> * update to cif 2.0 api (#154) * CIF-2131 - remove "id" support for AEM Venia (#151) * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * CIF-1964 - Show staged flag in product component (#115) * add css for "staged" flag on product component * update Venia product component to CIF v2 * update Magento GraphQL dependency * use 2.4.2 EE compatible connector * CIF-1965 - Show staged flag in productlist component (#118) * use productlist v2 component * update css for consistent "staged" flag in product and productlist * CIF-2131 - remove "id" support for AEM Venia Co-authored-by: Christophe Jelger <jelger@adobe.com> Co-authored-by: Levente Santha <levente@adobe.com> Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com> * CIF-2062 - adjust UrlProvider config and Sling map (#150) - use the newly introduced, fixed patterns for the UrlProvider * CIF-2143: Create Product Recommendations AEM component (#152) * CIF-2038: Migrate to CircleCI contexts (#155) * CIF-2153 - use Button v2 (#156) * CIF-2193: use CIF page v2 component (#159) * CIF-1926: add minimal default styling for cif navigation (#158) * CIF-1380: add product collection component styling (#157) * use product collection v2 and searchresults v2 in Venia * added Venia styling for productcollection component * cleaned up Venia styling for productlist and searchresults component * CIF-2155: update to use new v2 commerce teaser (#162) * CIF-2222: enable storefront context rendering (#167) * CIF-2227 - add missing image alt attribute for product teaser component (#166) * CIF-2227 - add missing image alt attribute for product teaser component * CIF.2227 - improve tests * CIF-2227 - fix test * Fix unit tests broken by UrlProvider package change (#168) * CIF-2211 - Update core WCM dependency to latest for CIF components (#165) * CIF-2211 - Update core WCM dependency to latest for CIF components * updated core.wcm.components.version to 2.17.2 * CIF-2211 - Update core WCM dependency to latest for CIF components * updated docker images * CIF-2211 - Update core WCM dependency to latest for CIF components * stick to the circleci-aem:6.5.8-azul image in CI for now * releng - Update CIF Core Components to 2.0.0 (#169) * CIF-2144 - Create a React project with a Recommendation component (#153) * CIF-2144 - Add basic extension react component project * CIF-2144 - Add support for Apollo client dependency sharing * CIF-2144 - Add PortalPlacer * CIF-2143: Add product recs to Venia * CIF-2143: Fix dependencies * CIF-2144 - Add todo * CIF-2143: Fix dependencies in all package * CIF-2144 - Update i18n config * CIF-2144 - Add feedback * CIF-2144 - Rename npm package * CIF-2144 - Update npm dependencies * Update GraphQL Client Version * CIF-2144 - Update npm dependencies * CIF-2111 - Add E2E test for product recommendation component (#161) * CIF-2144 - Add basic extension react component project * CIF-2144 - Add support for Apollo client dependency sharing * CIF-2144 - Add PortalPlacer * CIF-2143: Add product recs to Venia * CIF-2143: Fix dependencies * CIF-2144 - Add todo * CIF-2143: Fix dependencies in all package * CIF-2144 - Update i18n config * CIF-2144 - Add feedback * CIF-2111 - Add E2E test for product recommendation component Co-authored-by: Laurentiu Magureanu <magurean@adobe.com> Co-authored-by: Dirk Rudolph <diru91@gmail.com> * fix unit tests for injector specific annotations (#175) * CIF-2251: adds sitemap configurations (#173) * add sitemap configurations * update dispatcher rules * CIF-1502 - XF based page header with authoring support (#176) * CIF-1502 - XF based page header with authoring support * enabled v2 for header components * added experimental logo component * updated header XF for the Venia header * added XF based header to page templates and template types * enabled header components in Venia XF editor * CIF-1502 - XF based page header with authoring support * snapshot dependency for CIF components * CIF-1502 - XF based page header with authoring support * fixing ITs * CIF-1502 - XF based page header with authoring support * smaller fixes * CIF-1502 - XF based page header with authoring support * smaller fixes * CIF-2177 - Expose configured product identifiers for components (#177) * Update the overlaid Product Teaser component. * @releng Update to graphql-client 1.7.4 (#180) Co-authored-by: Daniel Platon <platon@adobe.com> Co-authored-by: Levente Sántha <levente@adobe.com> * CIF-2272 - Cannot close category filter accordion once it is open (#179) * CIF-2272 - Cannot close category filter accordion once it is open * added UI test * CIF-2272 - Cannot close category filter accordion once it is open * fixed UI tests * CIF-2291 - Cleanups in searchbar component (#178) * CIF-1502 - XF based page header with authoring support * enabled v2 for header components * added experimental logo component * updated header XF for the Venia header * added XF based header to page templates and template types * enabled header components in Venia XF editor * CIF-1502 - XF based page header with authoring support * snapshot dependency for CIF components * CIF-1502 - XF based page header with authoring support * fixing ITs * CIF-1502 - XF based page header with authoring support * smaller fixes * CIF-1502 - XF based page header with authoring support * smaller fixes * CIF-2291 - Cleanups in searchbar component * adapted searchbar stying to new CSS classes * enabled searchbar clientlib v2 * added UI test * CIF-2291 - Cleanups in searchbar component * added UI test * CIF-2291 - Cleanups in searchbar component * fixed CSS after merge * CIF-2291 - Cleanups in searchbar component * fixed UI test for AEM 6.5 Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com> * releng - update CIF components to 2.1.0 (#183) * CIF-2161 - Align Venia profiles with WKND (#174) * CIF-2222: Add storefront context config * ignore node_modules when linting * ignore dependencies when linting * refactor venia to align wknd (WIP) * refactor venia to align wknd * refactor venia to align wknd * fix venia.all name * minor fixes to comments etc., bind scm goals of prepare-release to install phase * adapt to tech grooming discussion * fix classic module includes * fix its * revert change on test data * fix all package dependencies * add missing wcm cc dependnecy * add missing dependency to magento-graphql bundle for cloud * rename withClassic to classic and update README.md Co-authored-by: Laurentiu Magureanu <magurean@adobe.com> * CIF-2330 - Update Venia CI to latest cloud image (#182) * update base image and tests * do not assert on a particular headline tag anymore * In order to be compatible to both cloud and onprem we should not assert on h2 or h3 anymore as one is used by cloud and the other on prem. * update to latest snapshot * fix element selectors * use latest public release Co-authored-by: Markus Haack <mhaack@adobe.com> Co-authored-by: Christophe Jelger <jelger@adobe.com> Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com> Co-authored-by: Daniel Platon <dplaton@pm.me> Co-authored-by: Daniel Platon <platon@adobe.com> Co-authored-by: Laurentiu Magureanu <magurean@adobe.com> Co-authored-by: Dirk Rudolph <diru91@gmail.com> Co-authored-by: Dirk Rudolph <drudolph@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove "id" support for AEM Venia, related to adobe/aem-core-cif-components#588
This PR is based on
2.0.0eebranch of Venia and CIF Core Components. ITs currently fail until we have merged adobe/aem-core-cif-components#588.Related Issue
CIF-2131
Motivation and Context
Clean up deprecated usage of
idfor catgeories.How Has This Been Tested?
Existing ITs.
Screenshots (if appropriate):
Types of changes
Checklist: