-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to amazonlinux:2.0.20200722.0-with-sources to build Chrome 85 #258
Conversation
Thanks for contributing this! I do encounter two problems trying to just build the headless-chrome on an AWS Linux 2 EC2 instance using
Any guesses why these two would be missing? |
Hi @teledyn, I have a branch I'm working on that fixes those two issues and compiles successfully. At the moment I'm running into issues with chromedriver, but the only thing I did different to get it to compile was update the amazon linux ami docker image. See my most recent commit on this branch. Once I get the chromedriver new session bug fixed I'll post my findings here. |
As an update, this branch works and compiles correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @skunkworker — Thank you for your effort!
can we have this merged? |
Update AMI to
amazonlinux:2.0.20200406.0
Changed the git clone to be a shallow clone on the
$RELEASE
tag, making the download much quicker.I was able to successfully build chrome
83.0.4103.61
with this branch.