-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker 18.09.0-ce-tp6 #171
base: develop
Are you sure you want to change the base?
Conversation
Use a newer version of docker to avoid 8GB file size bug in the current AWS linux package
Successfully used to build 72.0.3590.0 |
awesome job @mikenz! can't wait :) |
@adieuadieu Any chance you can merge this so the automated builds start working again? Thanks |
@mikenz shouldn't this be changed to |
@skunkworker yes. If @adieuadieu is interested in restoring the automated builds I'll happily update the PR. |
Hi @mikenz I tried your branch but I couldn't build chromium. I used Thanks! |
@adieuadieu , please can you have a look at this PR? @mikenz has done really amazing work. |
Hi @mikenz. I'm late to the party. I'm a little worried about the maintainability of the hard-coded docker value here. (The irony—or is it hypocrisy—of that statement is not lost on me..) Is the root issue here that the docker package contained in yum's repository is outdated, hence the manual install? Would this also be resolved by using a newer version of ubuntu on the EC2 instance? |
@mikenz I should also add, thank you for your efforts and raising this PR. |
So without some changes Chrome 75? ( I think it's 75) and above won't build on the older environment as it stands right now. Though I do have a fork that builds using |
@skunkworker please do create a PR, even if it isn't merged, the rest of the community would benefit from it. |
Use a newer version of docker to avoid 8GB file size bug in the current AWS linux package. Addresses #166