Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unnecesarily loop in the static menu. #660

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/router/modules/ADempiere/menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,15 +155,22 @@ function getRouteFromMenuItem({ menu, roleUuid, organizationUuid }) {
/**
* Grant visibility to static routes based on current role permissions
* @author elsiosanchez <elsiosanches@gmail.com>
* @author Edwin Betancourt <EdwinBetanc0urt@outlook.com>
* @param {object} staticRoutes static routes
* @param {object} permiseRole role permissions
* @returns {object} routes with hidden/show
*/
function hidenStactiRoutes({ staticRoutes, permiseRole }) {
if (!permiseRole.isAllowInfoProduct) {
return staticRoutes
}

return staticRoutes.map(route => {
if (route.path === '/ProductInfo') {
return {
...route,
hidden: !permiseRole.isAllowInfoProduct
// is hidden by default
hidden: false
EdwinBetanc0urt marked this conversation as resolved.
Show resolved Hide resolved
}
}
return {
Expand Down