Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unnecesarily loop in the static menu. #660

Conversation

EdwinBetanc0urt
Copy link
Collaborator

Bug report / Feature

The static menu item is traversed to modify the visibility of the ProductInfo item, only if the isAllowInfoProduct role attribute is set to true.
fixes #659

Other relevant information

  • Your OS: Linux Mint 19.1 Cinnamon x64.
  • Web Browser: Mozilla Firefox 85.0.
  • Node.js version: 12.20.0.
  • adempiere-vue version: 4.3.1.

src/router/modules/ADempiere/menu.js Outdated Show resolved Hide resolved
@yamelsenih
Copy link
Member

Great catch

@yamelsenih yamelsenih merged commit e9d1613 into adempiere:develop Mar 21, 2021
@EdwinBetanc0urt EdwinBetanc0urt deleted the bugfix/unnecessarily-loop-static-menu branch May 27, 2021 03:28
EdwinBetanc0urt pushed a commit to EdwinBetanc0urt/adempiere-vue that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Unnecessarily loop through the static menu
2 participants