Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowed to set extra attributes #2786

Merged
merged 1 commit into from
Jun 15, 2020
Merged

allowed to set extra attributes #2786

merged 1 commit into from
Jun 15, 2020

Conversation

NayanKhedkar
Copy link
Member

@NayanKhedkar NayanKhedkar commented Jun 2, 2020 •
edited by oliverfoster
Loading

@NayanKhedkar NayanKhedkar linked an issue Jun 2, 2020 that may be closed by this pull request
languagePicker: 'change language' popup needs a lang attribute #2785
Closed
tomgreenfield
tomgreenfield approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@tomgreenfield tomgreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️

@oliverfoster oliverfoster merged commit fefc8ce into master Jun 15, 2020
@oliverfoster oliverfoster deleted the issue/2785 branch June 15, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermartinfoster olivermartinfoster olivermartinfoster approved these changes

@moloko moloko moloko approved these changes

@tomgreenfield tomgreenfield tomgreenfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

languagePicker: 'change language' popup needs a lang attribute
5 participants
@NayanKhedkar @tomgreenfield @moloko @olivermartinfoster @oliverfoster