Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added language specific class to popup #41

Merged
merged 4 commits into from
Jul 1, 2020
Merged

added language specific class to popup #41

merged 4 commits into from
Jul 1, 2020

Conversation

NayanKhedkar
Copy link
Member

@NayanKhedkar NayanKhedkar commented Jun 1, 2020 •
edited by oliverfoster
Loading

@NayanKhedkar NayanKhedkar mentioned this pull request Jun 1, 2020
Closed
@NayanKhedkar NayanKhedkar mentioned this pull request Jun 2, 2020
Merged
@moloko moloko requested a review from guywillis June 26, 2020 09:59
@guywillis
Copy link
Contributor

Please update L50

Suggestion:

promptObject._classes = 'is-rtl is-lang-' + newLanguage;

@guywillis guywillis mentioned this pull request Jun 29, 2020
Closed
@moloko
Copy link
Contributor

moloko commented Jun 29, 2020

Please update L50

Suggestion:
promptObject._classes = 'is-rtl is-lang-' + newLanguage;

Definitely needs doing but should be able to do this slightly neater further up... gimme a sec and I'll add a suggestion

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 0cafedd into master Jul 1, 2020
@oliverfoster oliverfoster deleted the issue/2785 branch July 1, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@guywillis guywillis guywillis approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@moloko moloko Awaiting requested review from moloko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NayanKhedkar @guywillis @moloko @oliverfoster @cahirodoherty-learningpool