Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/2645 Added manifest creation and loading #2717

Merged
merged 6 commits into from
Apr 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 45 additions & 16 deletions grunt/config/babel.js
Original file line number Diff line number Diff line change
@@ -1,22 +1,51 @@
module.exports = {
options: {
sourceMap: true,
inputSourceMap: true,
sourceType: 'script',
minified: true,
comments: false,
presets: [
[
'@babel/preset-env',
{
"targets": {
"ie": "11"
compile: {
options: {
inputSourceMap: false,
sourceType: 'script',
minified: true,
comments: false,
presets: [
[
'@babel/preset-env',
{
"targets": {
"ie": "11"
}
}
}
]
]
]
},
files: [{
"expand": true,
"cwd": "<%= tempdir %>",
"src": [
"adapt.min.js"
],
"dest": "<%= outputdir %>adapt/js/",
"ext": ".min.js"
}]
},
dist: {
dev: {
options: {
sourceMap: true,
inputSourceMap: true,
sourceType: 'script',
retainLines: true,
minified: false,
compact: false,
comments: true,
presets: [
[
'@babel/preset-env',
{
"targets": {
"ie": "11"
}
}
]
]
},
files: [{
"expand": true,
"cwd": "<%= tempdir %>",
Expand All @@ -27,4 +56,4 @@ module.exports = {
"ext": ".min.js"
}]
}
};
};
4 changes: 2 additions & 2 deletions grunt/config/watch.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ module.exports = {
tasks: ['handlebars', 'javascript:dev']
},
courseJson: {
files: ['<%= sourcedir %>course/**/*.<%= jsonext %>'],
tasks: ['jsonlint', 'check-json', 'newer:copy:courseJson', 'schema-defaults']
files: ['<%= sourcedir %>course/**/*.<%= jsonext %>', '<%= outputdir %>course/*/language_data_manifest.js'],
tasks: ['language-data-manifests', 'jsonlint', 'check-json', 'newer:copy:courseJson', 'schema-defaults']
},
courseAssets: {
files: ['<%= sourcedir %>course/<%=languages%>/*', '!<%= sourcedir %>course/<%=languages%>/*.<%= jsonext %>'],
Expand Down
3 changes: 2 additions & 1 deletion grunt/tasks/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@ module.exports = function(grunt) {
'build-config',
'copy',
'schema-defaults',
'language-data-manifests',
'handlebars',
'tracking-insert',
'javascript:compile',
'babel',
'babel:compile',
'clean:dist',
'less:compile',
'replace',
Expand Down
3 changes: 2 additions & 1 deletion grunt/tasks/dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@ module.exports = function(grunt) {
'build-config',
'copy',
'schema-defaults',
'language-data-manifests',
'handlebars',
'tracking-insert',
'javascript:dev',
'babel',
'babel:dev',
'less:dev',
'replace',
'scripts:adaptpostbuild',
Expand Down
3 changes: 2 additions & 1 deletion grunt/tasks/diff.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@ module.exports = function(grunt) {
'build-config',
'copy',
'schema-defaults',
'language-data-manifests',
'newer:handlebars:compile',
'tracking-insert',
'newer:javascript:dev',
'babel',
'babel:dev',
'newer:less:dev',
'replace',
'scripts:adaptpostbuild',
Expand Down
7 changes: 7 additions & 0 deletions grunt/tasks/language-data-manifests.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
module.exports = function(grunt) {
const Helpers = require('../helpers')(grunt);
grunt.registerTask('language-data-manifests', 'Creates a manifest for each set of language data files', function() {
const languages = Helpers.getFramework({ useOutputData: true }).getData().languages;
languages.forEach(language => language.saveManifest());
});
};
3 changes: 2 additions & 1 deletion grunt/tasks/server-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@ module.exports = function(grunt) {
'_log-vars',
'build-config',
'copy',
'language-data-manifests',
'less:' + requireMode,
'handlebars',
'javascript:' + requireMode,
'babel',
'babel:' + requireMode,
'replace',
'scripts:adaptpostbuild',
'clean:temp'
Expand Down
6 changes: 0 additions & 6 deletions src/core/js/collections/adaptCollection.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,7 @@ define([
class AdaptCollection extends Backbone.Collection {

initialize(models, options) {
this.url = options.url;
this.once('reset', this.loadedData, this);
if (!this.url) return;
this.fetch({
reset: true,
error: () => console.error('ERROR: unable to load file ' + this.url)
});
}

loadedData() {
Expand Down
23 changes: 23 additions & 0 deletions src/core/js/collections/adaptSubsetCollection.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
define([
'core/js/adapt',
'./adaptCollection'
], function(Adapt, AdaptCollection) {

class AdaptSubsetCollection extends AdaptCollection {

initialize(models, options) {
super.initialize(models, options);
this.parent = options.parent;
this.listenTo(this.parent, 'reset', this.loadSubset);
}

loadSubset() {
this.set(this.parent.filter(model => model instanceof this.model));
this._byAdaptID = this.groupBy('_id');
}

}

return AdaptSubsetCollection;

});
Loading