-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue/2645 Added manifest creation and loading #2717
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cahirodoherty-learningpool
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
tomgreenfield
approved these changes
Apr 14, 2020
tomgreenfield
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grunt build && grunt server
is now giving me
adapt.min.js:1 Uncaught ReferenceError: Logger is not defined
tomgreenfield
approved these changes
Apr 14, 2020
chetan-hajare
approved these changes
Apr 14, 2020
This was referenced Apr 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2645
PR goes into #2714 then into #2713 then into #2711 then into master
build.js
andconfig.json
are still fixed filenames outside of the language folders).{ "_type": "" }
,{ "_component": "" }
or{ "_model": "" }
attribute on each JSON file object as this denotes the corresponding model inside the framework.{ "_type": "course" }
object.Added
language-data-manifests
Changed
src/core/js/data.js
to load manifest, files and become the collection for all models. It now has no references to the menu, page, article, block and component structuresrc/core/js/mpabc.js
AdaptCollection
so that it is no longer a data loader, only a container.Deprecated
Adapt.contentObjects
,Adapt.articles
,Adapt.blocks
,Adapt.components
in favour ofAdapt.data
Testing
Tested with languagePicker, works as normal.
change
events trigger fromAdapt.data
andAdapt.blocks
,Adapt.components
etc as intended