Added 'ie' class for Internet Explorer 10 and 11 #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is added in addition to the 'internet explorer' class.
oliverfoster
reviewed
Apr 5, 2017
src/core/js/device.js
Outdated
| var browserString = (Adapt.device.browser.toLowerCase() === 'msie') ? 'ie' : Adapt.device.browser.toLowerCase(); | ||
| var browser = Adapt.device.browser.toLowerCase(); | ||
| // Convert 'msie' to 'ie' for backwards compatibility. | ||
| var browserString = (browser === 'msie') ? 'ie' : browser; |
There was a problem hiding this comment.
var browserString = browser;
switch(browserString) {
case "msie": case "internet explorer":
browserString += " ie";
}or
var browserString = browser.replace(/^msie$|^internet explorer$/, browser + " ie" );There was a problem hiding this comment.
Wouldn't the switch statement also add the msie class though?
There was a problem hiding this comment.
var browserString = browser;
switch(browserString) {
case "msie": case "internet explorer":
browserString = "ie";
}or
var browserString = browser.replace(/^msie$|^internet explorer$/, "ie" );As per tom's latest suggestion on the original issue.
There was a problem hiding this comment.
OK, apologies, I missed Tom's comment about disregarding the internet explorer class.
Following PR it was agreed to drop the 'internet explorer' class, as this was a bug introduced in previous re-work to device.js.
oliverfoster
approved these changes
Apr 6, 2017
lc-thomasberger
approved these changes
Apr 6, 2017
src/core/js/device.js
Outdated
| var browserString = (Adapt.device.browser.toLowerCase() === 'msie') ? 'ie' : Adapt.device.browser.toLowerCase(); | ||
| var browser = Adapt.device.browser.toLowerCase(); | ||
| // Convert 'msie' and 'internet explorer' to 'ie'. | ||
| var browserString = browser.replace(/^msie$|^internet explorer$/, 'ie'); |
There was a problem hiding this comment.
Could we perhaps lose the string boundary tokens? I personally find it more readable without and less need to refer back to a regex reference.
var browserString = browser.replace(/msie|internet explorer/, 'ie');There was a problem hiding this comment.
I'm alright with that. They aren't needed, more implied by circumstance.
oliverfoster
approved these changes
Apr 6, 2017
tomgreenfield
approved these changes
Apr 6, 2017
sarveshwar-gavhane
approved these changes
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is added in addition to the 'internet explorer' class.