Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in reporting of Internet Explorer class #1504

Closed
brian-learningpool opened this issue Apr 5, 2017 · 5 comments
Closed

Inconsistency in reporting of Internet Explorer class #1504

brian-learningpool opened this issue Apr 5, 2017 · 5 comments
Assignees
@brian-learningpool
Labels
bug

Comments

@brian-learningpool
Copy link
Member

Internet Explorer 8 and 9 add a class of ie where as Internet Explorer 10 and 11 add a class of Internet Explorer.

It might be best to standardise these? My preference would be for ie.
@brian-learningpool brian-learningpool self-assigned this Apr 5, 2017
@oliverfoster
Copy link
Member

Agree. As an addition to the current classes at the moment.

@oliverfoster
Copy link
Member

https://github.com/adaptlearning/adapt_framework/pull/1349/files#diff-75a42229138a2ed8b53d97a3d1598089L137

This is where it got removed

@tomgreenfield
Copy link
Contributor

It's doubtful we need to keep the internet explorer class since it only surfaced by mistake after the removal of that line.

@oliverfoster
Copy link
Member

Fair enough.

@brian-learningpool
Copy link
Member Author

Merged in #1506.

@brian-learningpool brian-learningpool modified the milestone: v2.0.19 Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-learningpool brian-learningpool

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomgreenfield @brian-learningpool @oliverfoster