Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language Picker breaks tracking.js module completion criteria #2386

Closed
brian-learningpool opened this issue Mar 18, 2019 · 2 comments
Closed

Language Picker breaks tracking.js module completion criteria #2386

brian-learningpool opened this issue Mar 18, 2019 · 2 comments
Labels
bug high priority

Comments

@brian-learningpool
Copy link
Member

Subject of the issue

When using a multi-language course (with the Language Picker extension enabled), the tracking configuration doesn't correctly set the _completionCriteria from the config.json. This is due

Your environment

  • Adapt Framework v3.5 (though v4 is also affected)
  • Chrome
  • OS X

Steps to reproduce

  1. Create a course with the Language Picker extension enabled and more than one language.
  2. Launch the course and select a language.

Expected behaviour

_completionCriteria would be correctly read from config.json.

Actual behaviour

_completionCriteria is not read. The configModel:loadCourseData event is never fired.
brian-learningpool added a commit that referenced this issue Mar 18, 2019
@brian-learningpool
Resolves #2386, switches listeners out for 'configModel:dataLoaded'
1a6bae7 
The tracking, logging and scrolling modules were only checking the Adapt.config object so once it's loaded they are ok to continue.
@moloko moloko closed this as completed in 14bde8b Mar 19, 2019
@moloko
Copy link
Contributor

moloko commented Mar 19, 2019

reopening as this needs to be fixed in v3 as well (ideally)

@moloko moloko reopened this Mar 19, 2019
brian-learningpool added a commit that referenced this issue Mar 19, 2019
@brian-learningpool
Resolves #2386, switches listeners out for 'configModel:dataLoaded'
72f4fd1 
The tracking, logging and scrolling modules were only checking the Adapt.config object so once it's loaded they are ok to continue.
brian-learningpool added a commit that referenced this issue Mar 19, 2019
@brian-learningpool
Resolves #2386, switches listeners out for 'configModel:dataLoaded' (#…
bdc4a98 
…2388)

The tracking, logging and scrolling modules were only checking the Adapt.config object so once it's loaded they are ok to continue.
@brian-learningpool
Copy link
Member Author

Fixed in v3.5.1 and merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moloko @brian-learningpool