Skip to content

Commit

Permalink
Resolves #2386, switches listeners out for 'configModel:dataLoaded' (#…
Browse files Browse the repository at this point in the history
…2387)

The tracking, logging and scrolling modules were only checking the Adapt.config object so once it's loaded they are ok to continue.
  • Loading branch information
brian-learningpool authored and moloko committed Mar 19, 2019
1 parent 1d2c3d0 commit 14bde8b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/core/js/logging.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ define([

initialize: function() {

Adapt.once('configModel:loadCourseData', this.onLoadCourseData.bind(this));
Adapt.once('configModel:dataLoaded', this.onLoadConfigData.bind(this));

},

onLoadCourseData: function() {
onLoadConfigData: function() {

this.loadConfig();

Expand Down
2 changes: 1 addition & 1 deletion src/core/js/scrolling.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ define([

initialize: function() {
this._checkApp();
Adapt.once('configModel:loadCourseData', this._loadConfig.bind(this));
Adapt.once('configModel:dataLoaded', this._loadConfig.bind(this));
},

_checkApp: function() {
Expand Down
2 changes: 1 addition & 1 deletion src/core/js/tracking.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ define([
_assessmentState: null,

initialize: function() {
Adapt.once('configModel:loadCourseData', this.loadConfig.bind(this));
Adapt.once('configModel:dataLoaded', this.loadConfig.bind(this));
Adapt.on('app:dataReady', this.setupEventListeners.bind(this));
},

Expand Down

0 comments on commit 14bde8b

Please sign in to comment.