Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update P25Q16H.toml - Manufacturer ID cannot be in 2 files. #7

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

jpconstantineau
Copy link
Contributor

No description provided.

@dhalbert
Copy link
Contributor

dhalbert commented Nov 3, 2021

Is this a workaround for the nvm.toml parsing code problem you found? If so, we should fix that.

@jpconstantineau
Copy link
Contributor Author

jpconstantineau commented Nov 4, 2021

The CI problems I have on my CP PR did indicate that there was a duplicate key.
Removing this from the chip specific file and leaving in the manufacturer file should resolve that.

tomlkit.exceptions.KeyAlreadyPresent: Key "manufacturer_id " already exists.

I don't know why that didn't get picked up by my manual/local build for the Xiao RP2040.

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We can figure out whether this is a bug or correct over in

@jepler jepler merged commit 266ea20 into adafruit:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants