Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check desn't catch a problem that prevents cascade filter from running #4

Open
jepler opened this issue Nov 4, 2021 · 2 comments
Open

Comments

@jepler
Copy link
Member

jepler commented Nov 4, 2021

Background: In adafruit/circuitpython#5519 a revision was made to nvm.toml that just errored when trying to fill out the nvm header template. I wanted to add a check for toml file correctness, and first tried cascadetoml check, but that doesn't find the problem. Only cascadetoml cascade filter (or the equivalent, from Python) seems to do so.

I also don't know for sure whether it should be an error that manufacturer_id appears in both flash/puya/P25Q16H.toml and flash/puya/puya.toml, or if it should be allowed.

@jepler
Copy link
Member Author

jepler commented Nov 4, 2021

Here's the problematic ref in nvm.toml: adafruit/nvm.toml@73cedb3

@tannewt
Copy link
Member

tannewt commented Nov 4, 2021

It should be an error in check. I like to be strict about where things should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants