Update C6 IO14 pin name #9524
Closed
Update C6 IO14 pin name #9524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this, I didn't check the reverse of the board which clearly labels the pin IO14, the top side just says 12 and is next to many pins with more space for silkscreen and include the IO prefix in label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a pin named IO14 for the Feather ESP32-C6, but it's marked 12 on the silkscreen so was sticking in a PR to rename IO12 matching the other silkscreen pin naming (IO pin names), but not quite sure how I verify the GPIO name is correct as there is no PCB repo / guide yet. It's set as GPIO14 currently:
https://github.com/adafruit/circuitpython/blob/main/ports/espressif/boards/adafruit_feather_esp32c6_4mbflash_nopsram/pins.c#L57-L58
This closes #9523