Feather ESP32-C6 Rev B pin changes #9475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pardon the delay - reviewing now! |
|
@ladyada just checking on your testing on this. |
ladyada
requested changes
Aug 14, 2024
|
oki thats fine then
…On Wed, Aug 14, 2024 at 1:50 PM Scott Shawcroft ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ports/espressif/boards/adafruit_feather_esp32c6_4mbflash_nopsram/pins.c
<#9475 (comment)>
:
> @@ -66,18 +68,15 @@ static const mp_rom_map_elem_t board_module_globals_table[] = {
{ MP_ROM_QSTR(MP_QSTR_IO7), MP_ROM_PTR(&pin_GPIO7) },
{ MP_ROM_QSTR(MP_QSTR_D9), MP_ROM_PTR(&pin_GPIO7) },
D names are there so code is portable. When printing out the pin object,
the top name will be used. Only dir(board) will show the D names too.
—
Reply to this email directly, view it on GitHub
<#9475 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJINUNZXCCAAGOPRPLQEPTZROKH5AVCNFSM6AAAAABLVCHYLSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMZYHA2DMMBWGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ladyada
approved these changes
Aug 14, 2024
tannewt
added a commit
that referenced
this pull request
Aug 15, 2024
Merge #9475 from `9.1.x` into `main`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feather ESP32-C6 Rev B pin changes:
A2,A3swapped with A4, A5.D24andD25pin names. Not sure where these came from. @ladyada: I cannot find similar definitions for these, and I cannot find them in similar Arduino board defs. But happy to put them back if needed.I2C_POWERtoNEOPIXEL_I2C_POWER