Revert "Correctly raise OS error in socketpool_socket_recv_into()" #7629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7623.
@DavePutz: @jepler brought up that the
mp_raise
is being done in the internal routinesocketpool_socket_recv_into()
. There is already a raise incommon_halsocket_pool_socket_recv_into()
In general these routines belowcommon_hal...()
do not raise, because they are called from other places that don't expect them to raise, like the web workflow implementation.So I think we need to revert this, and figure out what routine is leaking the -116 returned by
socketpool_socket_recv_into()
into a general "count" return. I looked at this a bit, but couldn't find such a place.