Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Correctly raise OS error in socketpool_socket_recv_into()" #7629

Closed
wants to merge 1 commit into from

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Feb 22, 2023

Reverts #7623.

@DavePutz: @jepler brought up that the mp_raise is being done in the internal routine socketpool_socket_recv_into(). There is already a raise in common_halsocket_pool_socket_recv_into() In general these routines below common_hal...() do not raise, because they are called from other places that don't expect them to raise, like the web workflow implementation.

So I think we need to revert this, and figure out what routine is leaking the -116 returned by socketpool_socket_recv_into() into a general "count" return. I looked at this a bit, but couldn't find such a place.

@dhalbert
Copy link
Collaborator Author

Supersededby #7632.

@dhalbert dhalbert closed this Feb 22, 2023
@dhalbert dhalbert deleted the revert-7623-issue_7606 branch February 22, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant