Correctly raise OS error in socketpool_socket_recv_into() #7623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this needs further examination, as the routine where the exception is now raised is used in the web workflow and exceptions are not allowed to be raised in that code. I'll work on an alternate fix today. |
jepler
added a commit
to jepler/circuitpython
that referenced
this pull request
Mar 22, 2023
This reverts commit 7e6e824. Fixes adafruit#7770 The change in adafruit#7623 needs to be revered; the raise-site added in adafruit#7632 is the correct one and the one in socketpool needs to be reverted. This is not affecting 8.0.x because adafruit#7623 was not back-ported to there before we realized it was not a full fix. Both adafruit#7770 and adafruit#7606 should be re-tested. I didn't test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7606. Instead of returning an errno (which seems to lose the negative sign along the way and so will be interpreted as a received count) instead raise an OSerror with the errno in socketpool_socket_recv_into(). Tested using TLS with a local mosquitto server and io.adafruit.com.