Fix for Issue #6478 #6486
Merged
Fix for Issue #6478 #6486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
reviewed
Jun 14, 2022
tannewt
reviewed
Jun 14, 2022
Comment on lines
51
to
53
| #ifdef NRF_DEBUG_PRINT | ||
| static void print_wakeup_cause(nrf_sleep_source_t cause); | ||
| #endif |
There was a problem hiding this comment.
Sorry, I should have been more specific. The function below can be static and then this bit isn't needed.
|
My fault, I misinterpreted what you wrote. Should be fixed now. |
tannewt
added a commit
that referenced
this pull request
Jun 22, 2022
7.3.x #6486 backport nrf wakeup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for crash into safe mode when waking up (Issue #6478). Added a call to common_hal_displayio_release_displays() in board_deinit() to release the SPI display. Also snuck in a fix into common-hal/alarm/init.c that was causing a build failure if NRF_DEBUG_PRINT was defined. This may be related to Issue #6484, but I don't have hardware to test all the boards listed there.