Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builtin display invalid after fake deep sleep #6484

Closed
Neradoc opened this issue Jun 13, 2022 · 2 comments
Closed

Builtin display invalid after fake deep sleep #6484

Neradoc opened this issue Jun 13, 2022 · 2 comments
Labels
board New board or update to a single board bug displayio needs retest power
Milestone

Comments

@Neradoc
Copy link

Neradoc commented Jun 13, 2022

There are a few boards that support deep sleep and have a display, but the display becomes unusable after fake deep sleep, because the display is not released prior to being re-inited on wake. The FunHouse does release displays in board_deinit() and doesn't have the issue.

Should that be added to all relevant board.c ? Or should a call to release displays be added to the fake sleep code in main.c ? After board_deinit() for example. Some boards with an e-ink display have their own thing where they wait for the display to finish refreshing before releasing.

Example boards that need the fix that I could test:

  • adafruit_feather_esp32s2_tft
  • hiibot_iots2
  • lilygo_ttgo_t8_s2_st7789
  • adafruit_macropad_rp2040
@tannewt tannewt added bug displayio power board New board or update to a single board labels Jun 14, 2022
@tannewt tannewt added this to the 8.0.0 milestone Jun 14, 2022
@jepler
Copy link
Member

jepler commented Jul 6, 2022

In #6543 we release displays for all boards. Please re-test.

@Neradoc
Copy link
Author

Neradoc commented Jul 6, 2022

Yup, the issue is fixed with the boards I tested.

@Neradoc Neradoc closed this as completed Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board New board or update to a single board bug displayio needs retest power
Projects
None yet
Development

No branches or pull requests

3 participants