Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ESP-IDF to fix PinAlarm #6144

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Update ESP-IDF to fix PinAlarm #6144

merged 1 commit into from
Mar 15, 2022

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Mar 11, 2022

Fixes #5973

@tannewt tannewt added the espressif applies to multiple Espressif chips label Mar 11, 2022
dhalbert
dhalbert reviewed Mar 12, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have these two patches in our own fork:
adafruit/esp-idf@2775b6e

The I2C one it appears we don't need, but do you need the esp_phy one?

@tannewt
Copy link
Member Author

tannewt commented Mar 14, 2022

Ok, I've confirmed that import wifi still works ok on this change. For reference, the original issue is: #5662

@tannewt tannewt requested a review from dhalbert March 15, 2022 20:21
dhalbert
dhalbert approved these changes Mar 15, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit af9f80d into adafruit:main Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
espressif applies to multiple Espressif chips
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESP32S3 Sleep Behaviour using PinAlarm
2 participants
@tannewt @dhalbert