forked from espressif/esp-idf
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
couple fixes not yet in official esp-idf
- fix i2c crash - fix usb when enabling wifi Co-authored-by: Jeff Epler <jepler@gmail.com> Co-authored-by: Scott Shawcroft <scott@adafruit.com>
- Loading branch information
1 parent
0b46ac1
commit 2775b6e
Showing
2 changed files
with
4 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2775b6e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jepler Are these fixes in upstream at all? Should they be PR'd at all? My understanding is that the
i2c.c
fix is less important now that I am using the I2C wrapper routines, but it still seems like a good idea.I am asking because I may want to try to fix the minimum-1-second I2C timeout bug as well: adafruit/circuitpython#5908 (comment)
2775b6e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think upstream would want the i2c fix, so it's good that we changed our code not to need it. I don't know about the other one.