Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add neopixel support on PWM capable pins #5727

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Add neopixel support on PWM capable pins #5727

merged 3 commits into from
Dec 16, 2021

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Dec 15, 2021

It'll be hard to do PWM from them concurrently

Fixes #5697

@tannewt
Add neopixel support on PWM capable pins
2693e2c 
It'll be hard to do PWM from them concurrently

Fixes micropython#5697
@tannewt tannewt added enhancement broadcom Raspberry Pis with Broadcom chips labels Dec 15, 2021
@tannewt tannewt added this to the 8.0.0 milestone Dec 15, 2021
@tannewt tannewt requested a review from dhalbert December 15, 2021 01:02
dhalbert
dhalbert approved these changes Dec 16, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test with hardware, but know you did.

You added ulab to the modules, but it's still turned off. Do you want to turn it on here or in the next PR?

@tannewt
Copy link
Member Author

tannewt commented Dec 16, 2021

pixelbuf needed it. I'll enable it in my branch so it comes in the next PR. Thanks!

@tannewt tannewt merged commit 3f50453 into adafruit:main Dec 16, 2021
hathach pushed a commit to hathach/circuitpython that referenced this pull request Dec 23, 2021
@btongminh @dpgeorge
windows/Makefile: Add .exe extension to executables name.
3d9af87 
Uses the same logic applied in 5b57ae9
to determine when to add .exe.

See related: adafruit#3310, adafruit#3361, adafruit#3370, adafruit#4143, adafruit#5727.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
broadcom Raspberry Pis with Broadcom chips enhancement
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Support neopixel on BCM
2 participants
@tannewt @dhalbert