Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new board Maker Nano RP2040 to branch 7.1.x. #5673

Merged

Conversation

waiweng83
Copy link

Hi, I would like to add this board to v7.1.x.

https://www.cytron.io/maker-nano-rp2040-simplifying-projects-with-raspberry-pi-rp2040

It's already merged to the main in PR #5668

Thanks.

@waiweng83
Copy link
Author

Should I be concerned about the test that failed?

@tannewt
Copy link
Member

tannewt commented Dec 6, 2021

This build error is a bug in our tooling. I'll try and rerun your build. That may fix it.

@waiweng83
Copy link
Author

This build error is a bug in our tooling. I'll try and rerun your build. That may fix it.

Thanks. But looks like it's still failing.

@dhalbert
Copy link
Collaborator

dhalbert commented Dec 8, 2021

@waiweng83 Could you try pushing an empty commit?

git commit --allow-empty -m "empty commit"
git push

That will reset the commit to merge against to the latest.

@waiweng83
Copy link
Author

@waiweng83 Could you try pushing an empty commit?

git commit --allow-empty -m "empty commit"
git push

That will reset the commit to merge against to the latest.

Thanks.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tannewt tannewt merged commit 3c8a05e into adafruit:7.1.x Dec 8, 2021
@waiweng83 waiweng83 deleted the add-maker-nano-rp2040-7.1.x branch September 12, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants