Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new board: Cytron Maker Nano RP2040 #5668

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

waiweng83
Copy link

Hi, can you please help to add this new board?

https://www.cytron.io/maker-nano-rp2040-simplifying-projects-with-raspberry-pi-rp2040

Thanks.

@waiweng83
Copy link
Author

May I know what's wrong with my PR causing the test to fail?
It seems like the files that causing the fail is not from my PR.

@dhalbert
Copy link
Collaborator

dhalbert commented Dec 6, 2021

May I know what's wrong with my PR causing the test to fail? It seems like the files that causing the fail is not from my PR.

The failures are due to a new version of black being used to check the formatting of .py files in the source tree. There are some minor spacing changes it wants. I added these changes in #5667 but if that is not going to be accepted right away I can make a new PR that is just the spacing changes, and that should get approved quickly. I will check with the other core developers.

@dhalbert
Copy link
Collaborator

dhalbert commented Dec 6, 2021

Your PR is otherwise fine, so I don't see why the formatting issues should hold it up.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit c369f67 into adafruit:main Dec 6, 2021
@dhalbert
Copy link
Collaborator

dhalbert commented Dec 6, 2021

Note that this PR is against main. We have now made a branch, 7.1.x, so this will not get into 7.1.0, but will be in the 7.2.x series and later. If you want it in 7.1.x, could you make a PR against 7.1.x? It could just be a cherry-pick of the commits here.

@waiweng83
Copy link
Author

Note that this PR is against main. We have now made a branch, 7.1.x, so this will not get into 7.1.0, but will be in the 7.2.x series and later. If you want it in 7.1.x, could you make a PR against 7.1.x? It could just be a cherry-pick of the commits here.

Ok noted. Will do.

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants