NVM toml fix (MRAM) #5506
Merged
NVM toml fix (MRAM) #5506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5501.
I recently discovered external flash MRAM builds had stopped working on hardware (but built just fine). Originated around the time of 5810461 (thanks @dhalbert for helping me find this), but actual cause turned out to be two-fold:
devices.htoml generator was missing three variables :no_ready_bit,no_erase_cmd, andno_reset_cmd.spi_flash_init()was not setting the correct pins in the case of EXTERNAL_FLASH_QSPI_SINGLE. I'm not sure if it's just a quirk of the MRAM devices or if these#ifdefweren't set up properly, but since I'm the only one using EXTERNAL_FLASH_QSPI_SINGLE on the samd port, I just changed the pins back to what they had been (i.e. all of them).