raspberrypi: allow directly specifying the original boot .S file #4308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. all the necessary steps to transform it into a padded, checksummed file are now done by the build system. Since it is assigned by "?=", it _should_ be the case that individual builds can override it. I did not "test" this per se, but it gives the same content and checksum (except for the identifying comment with a path) as adafruit#4302.
tannewt
requested changes
Mar 2, 2021
|
That would be a good test, will do |
Presumably, switching it to generic hurt performance a bit. I verified that the build-raspberry_pi_pico/boot2_padded_checksummed.S built file has the same checksum as the old bs2_default_padded_checksummed.S
|
tested pico & feather rp2040 - both artifacts enumerate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. all the necessary steps to transform it into a padded, checksummed file are now done by the build system.
Since it is assigned by "?=", it should be the case that individual builds can override it.
I did not "test" this per se, but it gives the same content and checksum (except for the identifying comment with a path) as #4302.