Switch to generic flash init for now #4302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will support more flash chips at the expense of a performance hit when loading from the flash. This shouldn't hurt execution performance in most cases because Python code is parsed and stored in RAM. We'll refine this with micropython#4041
jepler
approved these changes
Mar 2, 2021
jepler
added a commit
to jepler/circuitpython
that referenced
this pull request
Mar 2, 2021
.. all the necessary steps to transform it into a padded, checksummed file are now done by the build system. Since it is assigned by "?=", it _should_ be the case that individual builds can override it. I did not "test" this per se, but it gives the same content and checksum (except for the identifying comment with a path) as adafruit#4302.
|
tested feather artifact, its good! |
ladyada
approved these changes
Mar 2, 2021
|
Superseded by #4308 |
jepler
added a commit
to jepler/circuitpython
that referenced
this pull request
Mar 6, 2021
.. all the necessary steps to transform it into a padded, checksummed file are now done by the build system. Since it is assigned by "?=", it _should_ be the case that individual builds can override it. I did not "test" this per se, but it gives the same content and checksum (except for the identifying comment with a path) as adafruit#4302.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will support more flash chips at the expense of a performance
hit when loading from the flash. This shouldn't hurt execution
performance in most cases because Python code is parsed and stored
in RAM.
We'll refine this with #4041