Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf.py (docs): Reorder the steps of the doc build #3335

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

jepler
Copy link
Member

@jepler jepler commented Aug 27, 2020

Since e121e26 (#3332), the shared bindings matrix uses the stubs. Therefore, we must build them! This should fix the failure to build the docs on readthedocs.org.

Neither @sommersoft nor I saw this locally since we had previously built the stubs. github CI didn't see it, because it manually builds the stubs in an earlier step of the build process, and does not clean the tree in between.

Since e121e26, the shared bindings matrix uses the stubs.
Therefore, we must build them!  This should fix the failure to build
the docs on readthedocs.org.

Neither @sommersoft nor I saw this locally since we had previously built
the stubs.  github CI didn't see it, because it manually builds the stubs
in an earlier step of the build process, and does not clean the tree
in between.
@jepler jepler requested a review from sommersoft August 27, 2020 01:42
@jepler
Copy link
Member Author

jepler commented Aug 27, 2020

Copy link
Collaborator

@sommersoft sommersoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 I actually had this thought when I first looked and saw circuitpython-stubs in the raw RTD logs, but I forgot to check the order. Thanks for following up on the RTD build!

@sommersoft sommersoft merged commit 58d5f99 into adafruit:main Aug 27, 2020
@jepler
Copy link
Member Author

jepler commented Aug 27, 2020

thanks for the merge again! I verified the docs build and that ulab appears in the matrix

@jepler jepler deleted the fix-doc-build branch November 3, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants