Shared bindings matrix ulab #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. this makes it take a fraction of the time, at least on systems with a lot of CPU threads. Even on my old laptop with a 2-core CPU it reduces the time from 55s to 27s.
This fixes a problem where things that were in extmod/ could not be listed.
sommersoft
approved these changes
Aug 26, 2020
This was referenced Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3331
Also adds code to speed up shared-bindings-matrix on multi-core systems, reducing it from ~1minute to ~30seconds on my laptop (2.6GHz 2C/4T) and from ~25 seconds to ~4 seconds on my desktop (3.6GHz 8C/16T)
The order of the files is different now (it is ordered by name, not by port-then-name), but I did my best effort to compare them and determine that only "ulab" was added to the matrix.