Fix all assignments affected by inline makefile comments #3333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making an assignment such as
CIRCUITPY_MODULENAME = 1
in a makefile, make will automatically add any trailing whitespace to the value of the assignment, which can cause evaluation failures down the line. Normally the compiler will warn you about this, but when the assignment is followed by an inline comment,CIRCUITPY_MODULENAME = 1 #somecomment
, this warning is omitted.Unaware of this I mistakenly included several inline comments in the STM32 and ESP32 ports, as well as in the copy-pastable "template" for a port's mpconfigport.mk file in the documentation. This PR removes all problematic inclusions of inline comments and updates the documentation.
Other additional minor improvements include updating the porting template to include COUNTIO, SDCARDIO and FRAMEBUFFERIO, which are now on by default, and a small python tool for quickly visualizing what modules in Circuitpython default as on, off, or are for large builds only. Note that it also turns Ulab back off for the ESP32, since including this module properly revealed that it is actually too big to fit with our current partition table!