Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all assignments affected by inline makefile comments #3333

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Fix all assignments affected by inline makefile comments #3333

merged 3 commits into from
Aug 27, 2020

Conversation

hierophect
Copy link
Collaborator

When making an assignment such as CIRCUITPY_MODULENAME = 1 in a makefile, make will automatically add any trailing whitespace to the value of the assignment, which can cause evaluation failures down the line. Normally the compiler will warn you about this, but when the assignment is followed by an inline comment, CIRCUITPY_MODULENAME = 1 #somecomment, this warning is omitted.

Unaware of this I mistakenly included several inline comments in the STM32 and ESP32 ports, as well as in the copy-pastable "template" for a port's mpconfigport.mk file in the documentation. This PR removes all problematic inclusions of inline comments and updates the documentation.

Other additional minor improvements include updating the porting template to include COUNTIO, SDCARDIO and FRAMEBUFFERIO, which are now on by default, and a small python tool for quickly visualizing what modules in Circuitpython default as on, off, or are for large builds only. Note that it also turns Ulab back off for the ESP32, since including this module properly revealed that it is actually too big to fit with our current partition table!

@hierophect hierophect added stm espressif applies to multiple Espressif chips labels Aug 26, 2020
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing all of these. Very obscure!

@dhalbert dhalbert merged commit fe73cfb into adafruit:main Aug 27, 2020
@hierophect hierophect deleted the esp32-enable-ulab branch August 27, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
espressif applies to multiple Espressif chips stm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants