Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add native wifi API with ESP32S2 support #3326

Merged
merged 33 commits into from
Sep 10, 2020
Merged

Add native wifi API with ESP32S2 support #3326

merged 33 commits into from
Sep 10, 2020

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Aug 25, 2020

Fixes #2903

tannewt added 24 commits August 19, 2020 14:21
@tannewt
First crack at native wifi API
c5b8401
@tannewt
Scanning WIP. Need to sort out supervisor memory
1a6f4e0
@tannewt
Add debugging. Scanning doesn't crash but returns no results. Need to…
ddcff85 
… config station.
@tannewt
Add ipaddress
c62ab6e
@tannewt
Update to latest idf
cdab5e7
@tannewt
Fix ipaddress import and parse ipv4 strings
c53a72d
@tannewt
Ping work and start to add socketpool
3860991
@tannewt
Ping works!
7bdd243
@tannewt
SocketPool stubbed out
c9ece21
@tannewt
HTTP works with my adafruit_requests
eb2c388
@tannewt
SSL works until it runs out of memory
430530c
@tannewt
Turn on json and enable socket.close
b3a449c
@tannewt
Add espidf module.
1034cc1
@tannewt
Remove debug prints
dcc42f6
@tannewt
Disable wifi debug logging and memory log
9602ee6
@tannewt
Add basic error handling
eb8b42a
@tannewt
Add error handling w/temp debug logs
80b15f6
@tannewt
Make socket reads interruptable
701e80a
@tannewt
Add missing include
da61845
@tannewt
Fix espidf.MemoryError print
69fc872
@tannewt
Fix SocketPool radio check
f3bc712
@tannewt
Add hash to Socket so it can be used in dicts
380cbfb
@tannewt
Merge remote-tracking branch 'adafruit/main' into native_wifi
8b71e26
@tannewt
Update translations
6fbeb28
@tannewt tannewt added the espressif applies to multiple Espressif chips label Aug 25, 2020
@tannewt tannewt requested a review from dhalbert August 25, 2020 23:43
dhalbert
dhalbert requested changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I am impressed by how clean the code is. Maybe that also says something about the ESP-IDF API being reasonable.

ports/esp32s2/common-hal/socketpool/Socket.c Outdated Show resolved Hide resolved
ports/esp32s2/common-hal/socketpool/Socket.c Outdated Show resolved Hide resolved
ports/esp32s2/common-hal/socketpool/Socket.c Outdated Show resolved Hide resolved
ports/esp32s2/common-hal/socketpool/SocketPool.c Outdated Show resolved Hide resolved
ports/esp32s2/common-hal/socketpool/SocketPool.c Outdated Show resolved Hide resolved
shared-bindings/socketpool/__init__.c Show resolved Hide resolved
shared-bindings/wifi/Radio.c Outdated Show resolved Hide resolved
shared-bindings/wifi/Radio.c Outdated Show resolved Hide resolved
shared-bindings/wifi/Radio.c Outdated Show resolved Hide resolved
shared-module/ipaddress/__init__.c Outdated Show resolved Hide resolved
tannewt
tannewt commented Sep 3, 2020
View reviewed changes
Copy link
Member Author

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, Dan. All is updated. Will test it next week. Just compiled it today.

ports/esp32s2/common-hal/socketpool/Socket.c Outdated Show resolved Hide resolved
ports/esp32s2/common-hal/ssl/SSLContext.c Show resolved Hide resolved
shared-bindings/ipaddress/__init__.c Show resolved Hide resolved
shared-bindings/socketpool/Socket.c Show resolved Hide resolved
ports/esp32s2/common-hal/wifi/Radio.c Show resolved Hide resolved
ports/esp32s2/supervisor/port.c Outdated Show resolved Hide resolved
ports/esp32s2/supervisor/port.c Outdated Show resolved Hide resolved
py/circuitpy_mpconfig.mk Outdated Show resolved Hide resolved
shared-bindings/socketpool/SocketPool.c Show resolved Hide resolved
shared-bindings/socketpool/__init__.c Show resolved Hide resolved
@tannewt
Copy link
Member Author

tannewt commented Sep 9, 2020

Ok, I've tested on both WROOM and WROVER Saola. I had a merge error with the WROOM version that has been fixed plus I added a safe mode in case the heap size is too large. Please take another look.

dhalbert
dhalbert approved these changes Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good. Thanks for all this work!

@tannewt tannewt merged commit 683462c into adafruit:main Sep 10, 2020
@jepler jepler mentioned this pull request Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
circuitpython api espressif applies to multiple Espressif chips network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get wifi working
2 participants
@tannewt @dhalbert