Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove bad-whitespace pylint directive #21

Merged
merged 3 commits into from
Sep 21, 2020
Merged

remove bad-whitespace pylint directive #21

merged 3 commits into from
Sep 21, 2020

Conversation

jepler
Copy link
Member

@jepler jepler commented Aug 23, 2020

This directive has been removed from pylint 2.6.0.

@jepler
Copy link
Member Author

jepler commented Aug 23, 2020

Fails due to unrelated lint diagnostics. Typical examples:

examples/wiznet5k_aio_post.py:7:0: C0411: third party import "import adafruit_requests as requests" should be placed before "from adafruit_wiznet5k.adafruit_wiznet5k import WIZNET5K" (wrong-import-order)
examples/wiznet5k_cheerlights.py:51:12: W0707: Consider explicitly re-raising using the 'from' keyword (raise-missing-from)

@kevinaj kevinaj mentioned this pull request Sep 20, 2020
Merged
@brentru brentru self-requested a review September 21, 2020 14:02
@brentru brentru merged commit 8ae1012 into adafruit:master Sep 21, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 24, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@c01bb3a)
1a7a2ef 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X_RVC to 1.0.1 from 1.0.0:
  > fixed heading order

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.5.0 from 1.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#23 from kevinaj/fix_ip_host
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#21 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 4.0.1 from 4.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#49 from askpatrickw/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.3.0 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#21 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_BNO08X, Adafruit_CircuitPython_BNO08X_RVC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @brentru