-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adafruit Logging is required #49
Conversation
askpatrickw
commented
Aug 25, 2020
```python Adafruit CircuitPython 5.0.0-beta.0-2634-gda61845f5-dirty on 2020-08-24; FeatherS2 with ESP32S2 >>> import os >>> os.listdir('/lib') ['adafruit_requests.mpy', 'adafruit_azureiot', '._adafruit_azureiot', 'adafruit_minimqtt', '._adafruit_minimqtt', 'adafruit_binascii.mpy', '._adafruit_binascii.mpy', 'adafruit_ntp.mpy', '._adafruit_ntp.mpy'] >>> import adafruit_minimqtt.adafruit_minimqtt as MINIQTT Traceback (most recent call last): File "<stdin>", line 1, in <module> File "adafruit_minimqtt/adafruit_minimqtt.py", line 47, in <module> ImportError: no module named 'adafruit_logging' ```
Since this is an explicit error, I don't think there is any additional context https://docs.python.org/3/library/exceptions.html
Since this is an explicit error, I don't think there is any additional context https://docs.python.org/3/library/exceptions.html
After a couple tries, I don't know how to fix the formatting and pylint errors unrelated to my README fix. If you can coach me on the fix, I'm happy to make it. |
I think you got the Pylint errors resolved. The current actions check wants So to fix it you'll need to run the black formatter locally on the file that it mentions. then make a new commit and push after it's done. this learn guide page details the black setup and usage process. Also worth mentioning that the Pylint check does come after black. So you might run black and get this resolved and then have something else from pylint to fix afterward. Though I think you got the original ones taken care of so it might turn green after black. |
But I wanted to be lazy and just make the edit in GitHub. :-) |
Thanks for adding this, will approve and merge once checks pass |
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X_RVC to 1.0.1 from 1.0.0: > fixed heading order Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.5.0 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#23 from kevinaj/fix_ip_host > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#21 from jepler/remove-bad-whitespace-directive Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 4.0.1 from 4.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#49 from askpatrickw/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.3.0 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#21 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_BNO08X, Adafruit_CircuitPython_BNO08X_RVC
Adafruit Logging is required