Add Missing type annotations #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I started looking at this, I can continue this evening. If you want to take a shot at the remaining ones, go for it, but I"m also happy to help with them if you'd like! |
|
the biggest issue is digitalio.Pull is an enum, right? so what is the value of digitalio.Pull.UP? |
|
So, I don't think they're technically Enums, but I think it's fair to treat it like they are. But the exact typing of "the value of |
tekktrik
requested changes
Sep 13, 2022
|
resubmitted for a review of missing items and changes |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 16, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 5.0.5 from 5.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#175 from rivques/main Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA8418 to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_TCA8418#5 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 2.1.8 from 2.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#43 from prcutler/issue40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2
submitted for review / comment
WARNING: I'm squishy on lines 338 and up!! (didn't find much info on the values, but pretty sure i've used variable/constant definitions which are sus.....)