Close #174 by sending entire webserver response to ESP32 in one go if possible #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by sending entire webserver response to esp32 in one go if possible
|
The checks failed, only due to a formatting issue. Could you run your changes through |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 16, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 5.0.5 from 5.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#175 from rivques/main Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA8418 to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_TCA8418#5 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 2.1.8 from 2.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#43 from prcutler/issue40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #174, and gets my connection speed on a Metro M4 Airlift Lite from about 800 bps to something like 178 kpbs when serving a webpage, though your mileage may vary. For some reason
finish_responsewould be called an empty array after the initial call with the intended response string, so I've left the original handling logic behind some type checks if that array ends up being non-empty. It's very possible I've misunderstood how WSGI is working here and more needs to be done with this, but it seems to handle what I've thrown at it.