Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation #41

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Update documentation #41

merged 1 commit into from
Sep 15, 2021

Conversation

rdoursenaud
Copy link
Contributor

No description provided.

tannewt
tannewt approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The continue move will make this a breaking change. @dherrada, please merge this before you do a new major release and note that the continue imports will have to be changed.

@rdoursenaud
Copy link
Contributor Author

Please don’t merge.

continue is a reserved Python keyword and my renaming may cause issues!

Should I revert to the previous naming (which prevented the documentation from properly building) or should I use continue_ to make it more in line with the other classes?

@rdoursenaud
Copy link
Contributor Author

rdoursenaud commented Sep 15, 2021 •
edited
Loading

OK, I’ve found what was preventing the docs from building.

Even though I think continue_ would have been a better name, I’ve settled for not breaking the API and keeping the original midi_continue.

@rdoursenaud rdoursenaud requested a review from tannewt September 15, 2021 11:31
tannewt
tannewt approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 6a5f834 into adafruit:main Sep 15, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 22, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@3dfaf62)
a65e6be 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.2.0 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#19 from bjones14/main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.4.1 from 1.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#10 from lesamouraipourpre/cpython
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#9 from lesamouraipourpre/multiplex

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.5.7 from 0.5.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#41 from PontusO/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#5 from adafruit/philb-bytes
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#3 from rhooper/grid
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#4 from adafruit/philb-buffer

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.1.0 from 8.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#135 from tannewt/connect_to_address

Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.4.3 from 1.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#41 from EMATech/mtc

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.9.2 from 1.9.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#49 from makermelissa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_UC8151D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdoursenaud @tannewt