Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the multiplex ratio to 0x7F #9

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

lesamouraipourpre
Copy link
Contributor

The recent changes to page/column mode dropped the multiplex ratio from 0x7F(128) to 0x3F(64). This breaks usage with a 128x128 display (eg. Pimoroni Mono OLED (128x128) I2C) - half the display is missing.

This reverts the multiplex ratio back to 0x7F(128)

I've tested this successfully with:

Was the multiplex ratio dropped to 0x3F for a different display which also needs tested?

@ladyada
Copy link
Member

ladyada commented Sep 15, 2021

hmmmm! ideally we would change the multiplex mode depending on the size, did ya wanna maybe try that? (it would happen in __init__)

@lesamouraipourpre
Copy link
Contributor Author

I can give that a go. I don't fully understand what the multiplex ratio means, but I'm assuming that height-1 gives the correct results:
eg.
height: 64 multiplex = 63 (0x3F)
height: 96 multiplex = 95 (0x5F) - I don't know of a display of this size, but 128x96 sounds plausible.
height: 128 multiplex = 127 (0x7F)

@lesamouraipourpre
Copy link
Contributor Author

Multiplex auto-determined by width or height and rotation.

Tested successfully on the FeatherWing with:
width=128, height=64, rotation=0 # or 180
width=64, height=128, rotation=90 # or 270

@ladyada
Copy link
Member

ladyada commented Sep 15, 2021

neat! cc @tannewt fyi

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tannewt tannewt merged commit 41014aa into adafruit:main Sep 16, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 22, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.2.0 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#19 from bjones14/main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.4.1 from 1.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#10 from lesamouraipourpre/cpython
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#9 from lesamouraipourpre/multiplex

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.5.7 from 0.5.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#41 from PontusO/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#5 from adafruit/philb-bytes
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#3 from rhooper/grid
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#4 from adafruit/philb-buffer

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.1.0 from 8.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#135 from tannewt/connect_to_address

Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.4.3 from 1.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#41 from EMATech/mtc

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.9.2 from 1.9.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#49 from makermelissa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_UC8151D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants