Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_and_get_feed function #81

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

kattni
Copy link
Contributor

@kattni kattni commented Dec 7, 2021

Adds a create_and_get_feed function to the library that attempts to get the feed, and if the feed does not exist, it creates and then gets the feed. Eliminates the need for the try/except in examples that try to create a feed.

Included an example of how it might be used, using the CPU temperature, which works on most CP-compatible boards.

@kattni kattni requested review from brentru, jerryneedell and a team December 7, 2021 17:06
Copy link

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- tested with adafruit feather esp32s2 and CP 7.1.0 -beta.1
Ran the new example - created new feed
Ran my own code - sent data to 6 existing feed

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kattni This looks good, thanks for adding it! 🚢

@brentru brentru merged commit 4b4db6f into adafruit:main Dec 7, 2021
@kattni
Copy link
Contributor Author

kattni commented Dec 7, 2021

@jerryneedell @brentru Thanks so much!

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 9, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.4.0 from 3.3.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME680#43 from caternuson/bme688_update
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.3.12 from 3.3.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#70 from dhalbert/make-package
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3231 to 2.4.10 from 2.4.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS3231#39 from tekktrik/docfix/correct-example-wday-num
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.6.1 from 0.6.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#51 from dhalbert/make-package
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#50 from mperino/main
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_FRAM to 1.3.10 from 1.3.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_FRAM#28 from tekktrik/fix/slice-notation
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_OV5640 to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_OV5640#10 from adafruit/stop-motion-example
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM69 to 2.1.6 from 2.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#41 from jerryneedell/jerryn_ticks
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM9x to 2.2.2 from 2.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_RFM9x#68 from jerryneedell/jerryn_ticks
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.6.0 from 5.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#81 from kattni/create-and-get-feed
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#77 from aerialist/main
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#80 from dhalbert/make-examples-packages
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.1 from 0.5.0:
  > fix exception printing

Updating https://github.com/adafruit/Adafruit_CircuitPython_binascii to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_binascii#13 from tekktrik/feature/add-typing
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.15.0 from 1.14.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#58 from FoamyGuy/cell_anchor_point

Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 2.1.8 from 2.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#21 from RufusVS/tone_frequency_0_fix
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.3.6 from 1.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#17 from caternuson/iss22
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 2.1.3 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#74 from dhalbert/make-package
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 3.0.3 from 3.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#81 from dhalbert/make-package
  > update rtd py version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants