-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overwrite-settings
to disable overwriting settings.xml
#82
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,8 +23,15 @@ async function run() { | |
core.getInput('server-username', {required: false}) || undefined; | ||
const password = | ||
core.getInput('server-password', {required: false}) || undefined; | ||
const overwriteSettings = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest to use the same approach like |
||
core.getInput('overwrite-settings', {required: false}) || 'true'; | ||
|
||
await auth.configAuthentication(id, username, password); | ||
await auth.configAuthentication( | ||
id, | ||
username, | ||
password, | ||
overwriteSettings === 'true' | ||
); | ||
} catch (error) { | ||
core.setFailed(error.message); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest setting
default: true
in YAML file.Details: https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#inputsinput_iddefault