Add overwrite-settings to disable overwriting settings.xml
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything holding this? |
|
@clarkbw @konradpabjan Is there any interested in me updating this PR to the latest |
| @@ -36,6 +36,9 @@ inputs: | |||
| settings-path: | |||
| description: 'Path to where the settings.xml file will be written. Default is ~/.m2.' | |||
| required: false | |||
| overwrite-settings: | |||
| description: 'Overwrite the settings.xml file if it exists. Default is "true".' | |||
| required: false | |||
There was a problem hiding this comment.
I suggest setting default: true in YAML file.
Details: https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#inputsinput_iddefault
| @@ -23,8 +23,15 @@ async function run() { | |||
| core.getInput('server-username', {required: false}) || undefined; | |||
| const password = | |||
| core.getInput('server-password', {required: false}) || undefined; | |||
| const overwriteSettings = | |||
There was a problem hiding this comment.
I suggest to use the same approach like actions/checkout: https://github.com/actions/checkout/blob/main/src/input-helper.ts#L118
May be we can wrap it in small util func
2 tasks
|
Closing as duplicate of #136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios there's already a valid Maven settings file which shouldn't or cannot be overwritten by actions/setup-java.
The
overwrite-settings(default:true) configuration setting enables users to disable the generation of the Maven settings file by actions/setup-java.Closes #79
Refs joschi/setup-jdk#11