Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JDKs with JavaFX #19

Closed
wants to merge 1 commit into from
Closed

Add support for JDKs with JavaFX #19

wants to merge 1 commit into from

Conversation

airsquared
Copy link

@airsquared airsquared commented Aug 31, 2019

I've tested this on my own repository, and it works well.

I wasn't sure what to set the name of the toolcache to, so I just changed it to 'fx-jdk' for JDKs with JavaFX and 'jdk' for JDKs without JavaFX (you might want to change this to something else).

To use this, just do:

- uses: airsquared/setup-java@master
  with:
    java-version: '1.8'
    javafx: true

Closes #18.

Also changes the toolcache to 'fx-jdk' for JDKs with JavaFX and 'jdk' for JDKs without JavaFX
@rmannibucau
Copy link

Hi,

can it be integrated please?

@airsquared
Copy link
Author

What do you mean by "integrated"?

@rmannibucau
Copy link

Merged, it prevents me to use gh actions and i'd like to avoid to fork the download logic again.

@giltene
Copy link
Contributor

giltene commented Nov 3, 2019

I've created a separate pull request #27 that covers the requested feature but with a different syntax than the one proposed here: The change introduces a new java-package option that supports jre, jdk, and jdk+fx as accepted values (defaults to jdk and retains current behavior unless jre or jdk+fx is specified). I believe that this syntax (a single option to cover current and possible future package types) is preferable to having individual booleans per package type.

The action is available for testing as foo-actions/setup-java@master

@konradpabjan
Copy link
Collaborator

Support for JavaFx was added with the following PR: #27

The README has also been updated with some information about how to use it.

I've also updated the releases tag so as long as you're using actions/setup-java@v1 then you should just be able to switch one of the parameters to use javafx

RVRX added a commit to RVRX/GoICasterCompanion that referenced this pull request Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for JavaFX builds
4 participants