Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up GitHub Actions #59

Closed
mrombout opened this issue Aug 30, 2019 · 2 comments
Closed

Set up GitHub Actions #59

mrombout opened this issue Aug 30, 2019 · 2 comments

Comments

@mrombout
Copy link
Owner

Let's get some of that GitHub Action!
@mrombout
Copy link
Owner Author

With the default set-up JavaFX is not supported, see actions/setup-java#18.

  • I could ditch JavaFX because the web version is going to be the main one anyway.
  • I could see if I can install a proper OracleJDK 8 with that (which should have JavaFX)
  • I suppose I could fork that action and add JavaFX support myself.

@mrombout mrombout mentioned this issue Aug 30, 2019
Open
@airsquared
Copy link

@mrombout I created a PR to setup-java (actions/setup-java#19) that adds support for JavaFX, so you can use that if it's merged(or you can use my fork directly).

@mrombout mrombout closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrombout @airsquared