Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2760: Leverage source and target dump options for sync. #2770

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Fixes #2760: Leverage source and target dump options for sync. #2770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Robo/Commands/Sync/SyncCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ public function syncDb() {
->arg($local_alias)
// @see https://github.com/drush-ops/drush/releases/tag/9.2.1
// @see https://github.com/acquia/blt/issues/2641
->option('--source-dump', sys_get_temp_dir() . '/tmp.sql')
->option('--source-dump', sys_get_temp_dir() . '/tmp.source.sql')
->option('--target-dump', sys_get_temp_dir() . '/tmp.target.sql.gz')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd these have different extensions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is odd. I initially had it without the gz and it failed on gzip -d /tmp/tmp.target.sql. Documentation is poor for these options, but I sifted through the issue queue and stumbled upon this PR that was merged into an old drush version - https://github.com/drush-ops/drush/pull/1996/files. It shows the target-dump option with the gz extension.

->option('structure-tables-key', 'lightweight')
->option('create-db');

Expand Down