Fixes #2760: Leverage source and target dump options for sync. #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
838e590 to
a3e1ba5
Compare
grasmash
reviewed
Apr 26, 2018
| @@ -134,7 +134,8 @@ public function syncDb() { | |||
| ->arg($local_alias) | |||
| // @see https://github.com/drush-ops/drush/releases/tag/9.2.1 | |||
| // @see https://github.com/acquia/blt/issues/2641 | |||
| ->option('--source-dump', sys_get_temp_dir() . '/tmp.sql') | |||
| ->option('--source-dump', sys_get_temp_dir() . '/tmp.source.sql') | |||
| ->option('--target-dump', sys_get_temp_dir() . '/tmp.target.sql.gz') | |||
There was a problem hiding this comment.
Odd these have different extensions?
There was a problem hiding this comment.
It is odd. I initially had it without the gz and it failed on gzip -d /tmp/tmp.target.sql. Documentation is poor for these options, but I sifted through the issue queue and stumbled upon this PR that was merged into an old drush version - https://github.com/drush-ops/drush/pull/1996/files. It shows the target-dump option with the gz extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.