Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use null check operator on potentially nil value in ConnectionClose messsage #105

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Don't use null check operator on potentially nil value in ConnectionClose messsage #105

merged 1 commit into from
Dec 5, 2023

Conversation

achilleasa
Copy link
Owner

This commit attempts to fix issue #104 by using a ?? operator to avoid raising a _CastError if a ConnectionClose message does not include a replyText field.

Fixes #104

@achilleasa
Don't use null check operator on potentially nil value in ConnectionC…
39baef3 
…lose message

This commit attempts to fix issue #104 by using a ?? operator to avoid
raising a _CastError if a ConnectionClose message does not include a
replyText field.
@coveralls
Copy link

Coverage Status

coverage: 93.043%. remained the same when pulling 39baef3 on dont-use-null-check-op-on-potentially-null-value into 4e2a811 on master.

@achilleasa achilleasa merged commit adae0c2 into master Dec 5, 2023
@achilleasa achilleasa deleted the dont-use-null-check-op-on-potentially-null-value branch December 5, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError thrown in _ClientImpl._handleException
2 participants
@achilleasa @coveralls