TypeError thrown in _ClientImpl._handleException

[rajmaniar]

I don't know the how to reproduce this but we just saw this in our logs:

type '_CastError' is not a subtype of type 'Exception'


package:dart_amqp/src/client/impl/client_impl.dart 225          _ClientImpl._handleException
package:dart_amqp/src/client/impl/client_impl.dart 189          _ClientImpl._handleMessage
dart:async                                                      _EventSinkWrapper.add
package:dart_amqp/src/protocol/io/amqp_message_decoder.dart 42  AmqpMessageDecoder.handleData
dart:async                                                      _EventSinkWrapper.add
package:dart_amqp/src/protocol/io/raw_frame_parser.dart 79      RawFrameParser.handleData

It seems like there might be two issues here:

• _handleException accepts a dynamic error but is trying to add it to the error stream which is typed Exception
• What in the _handleMessage is throwing the CastError

[achilleasa]

That's an odd error... Are you getting this with v0.2.5 of the client?

[achilleasa]

It looks like a _CastError is raised when a null check operator is used on a null value.

I examined the handleMessage implementation and found one potential location where this might happen (the other null checks in that method is unlikely to be used against a null value). Can you try the linked PR and let me know if the issue surfaces again?

[rajmaniar]

Thanks! I'll pull your branch in and see if it happens again.

[rajmaniar]

I forgot to report back, this fixed the null check issue. Feel free to close and merge the associated PR